vrozov commented on PR #5868: URL: https://github.com/apache/hive/pull/5868#issuecomment-3006599071
> Your solution has a limitation - it doesn't handle structs, such as a StructColumnVector that includes a TimestampColumnVector among its fields. That can be easily fixed. Note that your solution assumes that ORC readers use exclusively `fileReader.readerOptions()` to set `isUTC` flag in `TimestampColumnVector` and this is not always the case (as you can see from https://github.com/apache/orc/pull/2300). Another issue with your PR is that all that propagation of `fileReader.readerOptions()` to `RecordReaderImpl` is not necessary (obsolete) once https://github.com/apache/orc/pull/2300 is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
