ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2174274334
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -2187,6 +2088,10 @@ List<Partition> dropPartitions(String catName, String
dbName, String tblName,
PartitionDropOptions options)
throws NoSuchObjectException, MetaException, TException;
+ List<Partition> dropPartitions(String catName, String dbName, String tblName,
Review Comment:
Yes, I added a new `dropPartitions` method that takes an
`EnvironmentContext` in order to support the existing Iceberg table handling
logic.
More specifically, when dropping partitions in Iceberg,
`HiveIcebergMetaHook` sets `SKIP_DROP_PARTITION=true` in `EnvironmentContext`,
so that `ThriftHiveMetaStoreClient` does not proceed with the actual removal.
However, the current interface does not provide a method to pass
`EnvironmentContext`, so I added a new method to properly propagate it from the
hook to the underlying clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
