ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2174275744
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -575,21 +575,9 @@ void truncateTable(String dbName, String tableName,
List<String> partNames,
void truncateTable(String dbName, String tableName, List<String> partNames,
String validWriteIds, long writeId, boolean deleteData) throws
TException;
- /**
- * Truncate the table/partitions in the DEFAULT database.
- * @param catName catalog name
- * @param dbName
- * The db to which the table to be truncate belongs to
- * @param tableName
- * The table to truncate
- * @param partNames
- * List of partitions to truncate. NULL will truncate the whole
table/all partitions
- * @throws MetaException Failure in the RDBMS or storage
- * @throws TException Thrift transport exception
- */
- @Deprecated
- void truncateTable(String catName, String dbName, String tableName,
List<String> partNames)
- throws MetaException, TException;
+
+ void truncateTable(String catName, String dbName, String tableName, String
ref, List<String> partNames,
Review Comment:
Yes, I added a new `truncateTable` method that takes both
`cat.db.table.part` and `(validWriteIds, writeId, deleteData)` to unify the
existing `truncateTable` variants, each of which previously takes either the
category name or `{validWriteIds, writeId, deleteData}` stuffs.
I believe that extending an interface should be done carefully and kept to a
minimum. However, I added three methods to `IMetaStoreClient` to keep the
current logic. For `truncateTable`, we can retain the current interface at the
cost of handling two overloaded methods in each proxy. Please let me know if
you think it would be better not to extend `IMetaStoreClient` for this reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
