deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174495278
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ########## @@ -4292,17 +4294,16 @@ private List<Partition> add_partitions_core(final RawStore ms, String catName, tbl = ms.getTable(catName, dbName, tblName, null); if (tbl == null) { throw new InvalidObjectException("Unable to add partitions because " - + TableName.getQualified(catName, dbName, tblName) + - " does not exist"); + + TableName.getQualified(catName, dbName, tblName) + " does not exist"); } MTable mTable = getMS().ensureGetMTable(catName, dbName, tblName); db = ms.getDatabase(catName, dbName); - Set<PartValEqWrapperLite> partsToAdd = new HashSet<>(parts.size()); - List<Partition> partitionsToAdd = new ArrayList<>(parts.size()); + Set<PartValEqWrapperLite> partsToAdd = new HashSet<>(); List<FieldSchema> partitionKeys = tbl.getPartitionKeys(); - for (final Partition part : parts) { - if(isSkipColSchemaForPartition) { + Map<String, Partition> nameToPart = new LinkedHashMap<>(); + for (final Partition part : request.getParts()) { + if(request.isSkipColumnSchemaForPartition()) { Review Comment: nit: space -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org