deniskuzZ commented on code in PR #5910: URL: https://github.com/apache/hive/pull/5910#discussion_r2174503696
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ########## @@ -4264,13 +4264,15 @@ public boolean equals(Object obj) { } } - private List<Partition> add_partitions_core(final RawStore ms, String catName, - String dbName, String tblName, List<Partition> parts, final boolean ifNotExists, - boolean isSkipColSchemaForPartition, EnvironmentContext envContext) throws TException { + private List<Partition> add_partitions_core(final RawStore ms, + AddPartitionsRequest request) throws TException { + String catName = request.isSetCatName() ? request.getCatName() : getDefaultCatalog(conf); Review Comment: Should we move https://github.com/apache/hive/pull/5910/files#diff-90c669c961ab250c01087a409b31126cce7ac0672c40f465e7ee262ed7bcdaddR4598-R4599 here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org