deniskuzZ commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2172457324
########## ql/src/test/queries/clientpositive/acid_direct_delete.q: ########## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; Review Comment: why introduce a new q.test instead of extending the existing `acid_direct_update_delete.q`? ```` -- SORT_QUERY_RESULTS set hive.support.concurrency=true; set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; set hive.acid.direct.insert.enabled=true; DROP TABLE IF EXISTS test_update_bucketed; CREATE TABLE test_update_bucketed(id string, value string) CLUSTERED BY(id) INTO 10 BUCKETS STORED AS ORC TBLPROPERTIES('transactional'='true'); INSERT INTO test_update_bucketed values ('1','one'),('2','two'),('3','three'),('4','four'),('5','five'),('6','six'),('7','seven'),('8','eight'),('9','nine'),('10','ten'),('11','eleven'),('12','twelve'),('13','thirteen'),('14','fourteen'),('15','fifteen'),('16','sixteen'),('17','seventeen'),('18','eighteen'),('19','nineteen'),('20','twenty'); SELECT * FROM test_update_bucketed; DELETE FROM test_update_bucketed WHERE id IN ('2', '4', '12', '15'); UPDATE test_update_bucketed SET value='New value' WHERE id IN ('6', '11', '18', '20'); SELECT * FROM test_update_bucketed; DELETE FROM test_update_bucketed WHERE id IN ('2', '11', '10'); UPDATE test_update_bucketed SET value='New value2' WHERE id IN ('2', '18', '19'); SELECT * FROM test_update_bucketed; CREATE TABLE test_delete(id int) STORED AS ORC TBLPROPERTIES('transactional'='true'); INSERT INTO test_delete SELECT id FROM test_update_bucketed WHERE id <= 9; INSERT INTO test_delete SELECT id FROM test_update_bucketed WHERE id > 9; DELETE FROM test_delete WHERE id in (5, 13); SELECT * FROM test_delete; DROP TABLE test_update_bucketed; DROP TABLE test_delete; ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org