kokila-19 commented on code in PR #5901: URL: https://github.com/apache/hive/pull/5901#discussion_r2175519616
########## ql/src/test/queries/clientpositive/acid_direct_delete.q: ########## @@ -0,0 +1,18 @@ +set hive.mapred.mode=nonstrict; +set hive.support.concurrency=true; +set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; +set hive.acid.direct.insert.enabled=true; + +drop table if exists full_acid; + +set mapreduce.job.reduces=7; + +create external table ext(a int) stored as textfile; +insert into table ext values(1),(2),(3),(4),(5),(6),(7), (8), (9), (12); +create table full_acid(a int) stored as orc tblproperties("transactional"="true"); + +insert into table full_acid select * from ext where a != 3 and a <=7 group by a; Review Comment: I was just wondering why without group by the new test case was not reproducing the issue. We are selecting it from a text file and we needed to group by to distribute. And Yes, we don't need `group by ` in the `acid_direct_update_delete.q ` , so I have not added it. I mentioned I have rewritten in the sense that I have written the test case in the existing file and deleted the new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org