dengzhhu653 commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2178747662
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
the `clientWithHook` contains the hook and authorization, while the
temporary table doesn't need it, can we move this lawyer just above the
`thriftClient`?
We can also create a static `newClient` method to build the chain as we did
in SessionHiveMetaStoreClient before
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
The `clientWithHook` contains the hook and authorization, while the
temporary table doesn't need it, can we move this lawyer just above the
`thriftClient`?
We can also create a static `newClient` method to build the chain as we did
in SessionHiveMetaStoreClient before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
