ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2178826047
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
Temporary table has a dependency on Hook feature. Please refer to my design
proposal and okumin's comment at
[here](https://docs.google.com/document/d/1lppPj35fBOOCjGNIouoJCsniMPpyzWx3zcE7kvu0Be4/edit?disco=AAABhxTJ-TI).
Regarding authorization, I moved filterHook related logics to
`ThriftHiveMetaStoreClient`.
I also introduced `newClient` methods as you wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
