henrib commented on code in PR #5882:
URL: https://github.com/apache/hive/pull/5882#discussion_r2183168553
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -35,19 +38,33 @@
* Catalog & servlet factory.
*/
public class HMSCatalogFactory {
- private static final String SERVLET_ID_KEY =
"metastore.in.test.iceberg.catalog.servlet.id";
+ private static final String SERVLET_ID_KEY =
"metastore.in.test.iceberg.catalog.servlet.id";
- private final Configuration configuration;
- private final int port;
- private final String path;
+ /**
+ * Convenience soft reference to last catalog.
+ */
+ protected static final AtomicReference<Reference<Catalog>> catalogRef = new
AtomicReference<>();
Review Comment:
I've removed this and changed the logic in the latest iteration to check
whether a cached table still points to the most up to date location (reusing
@okumin idea).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
