ayushtkn commented on code in PR #5923:
URL: https://github.com/apache/hive/pull/5923#discussion_r2184791503


##########
packaging/src/docker/Dockerfile:
##########
@@ -26,9 +26,9 @@ ARG HADOOP_VERSION
 ARG HIVE_VERSION
 ARG TEZ_VERSION
 ONBUILD RUN apt-get update && apt-get -y install wget
-ONBUILD RUN wget 
https://archive.apache.org/dist/tez/$TEZ_VERSION/apache-tez-$TEZ_VERSION-bin.tar.gz
 && \
+ONBUILD RUN wget 
https://downloads.apache.org/tez/$TEZ_VERSION/apache-tez-$TEZ_VERSION-bin.tar.gz
 && \
  wget 
https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz
 && \

Review Comment:
   In current hive the hadoop version is 3.4.1 & that is there in 
downloads.apache.org
   https://downloads.apache.org/hadoop/core/hadoop-3.4.1/
   
   Most probably @dengzhhu653 didn't drop /dist from the path, 
downloads.apache.org doesn't have /dist in the path
   
   But using archive may be better, say today 3.4.1 isn't archived but later if 
it does or someone wants to build docker image with an older version of hadoop, 
that won't be found in downloads.apache.org where as archive.apache has all 
versions including the current ones
   https://archive.apache.org/dist/hadoop/common/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to