deniskuzZ commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2188049598
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,21 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = ThriftHiveMetaStoreClient.newClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache =
HiveMetaStoreClientWithLocalCache.newClient(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient =
SessionHiveMetaStoreClient.newClient(conf, clientWithLocalCache);
+ IMetaStoreClient clientWithHook =
HookEnabledMetaStoreClient.newClient(conf, hookLoader, sessionLevelClient);
+
if (conf.getBoolVar(ConfVars.METASTORE_FASTPATH)) {
- return new SessionHiveMetaStoreClient(conf, hookLoader, allowEmbedded);
+ return
org.apache.hadoop.hive.metastore.client.SynchronizedMetaStoreClient.newClient(conf,
clientWithHook);
Review Comment:
why are we wrapping with `SynchronizedMetaStoreClient``? was
`SessionHiveMetaStoreClient` synchronized?
````
if (!org.apache.commons.lang3.StringUtils.isEmpty(metaStoreUris)) {
// get a synchronized wrapper if the meta store is remote.
metaStoreClient =
HiveMetaStoreClient.newSynchronizedClient(metaStoreClient);
}
````
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,21 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = ThriftHiveMetaStoreClient.newClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache =
HiveMetaStoreClientWithLocalCache.newClient(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient =
SessionHiveMetaStoreClient.newClient(conf, clientWithLocalCache);
+ IMetaStoreClient clientWithHook =
HookEnabledMetaStoreClient.newClient(conf, hookLoader, sessionLevelClient);
+
if (conf.getBoolVar(ConfVars.METASTORE_FASTPATH)) {
- return new SessionHiveMetaStoreClient(conf, hookLoader, allowEmbedded);
+ return
org.apache.hadoop.hive.metastore.client.SynchronizedMetaStoreClient.newClient(conf,
clientWithHook);
Review Comment:
why are we wrapping with `SynchronizedMetaStoreClient``? was
`SessionHiveMetaStoreClient` synchronized?
````
if (!org.apache.commons.lang3.StringUtils.isEmpty(metaStoreUris)) {
// get a synchronized wrapper if the meta store is remote.
metaStoreClient =
HiveMetaStoreClient.newSynchronizedClient(metaStoreClient);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
