deniskuzZ commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3040996449
> I think we can even drop getSynchronizedMSC, since there is no unsynchronized MetaStoreClient; now all MetaStoreClients are wrapped by metastore.client.SynchronizedMetaStoreClient. I'm not sure why we introduced two redundant synchronization mechanism in HiveMetaStoreClient.newSynchronizedClient ([HIVE-1899](https://issues.apache.org/jira/browse/HIVE-1899)) and hive-exec SynchronizedMetaStoreClient ([HIVE-14204](https://issues.apache.org/jira/browse/HIVE-14204)), but I believe that we can unify them into a single class. I'm OK with going with any weaker changes as well, but I would like to hear your thoughts on the proposed commit. > (The commit can be found in [here](https://github.com/ngsg/hive/commit/71ed3c1f9d240c53de7418dfa8f8463fdc45dfd9).) The change makes sense given the current code, but not all clients were synchronized previously, were they? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
