deniskuzZ commented on code in PR #5841:
URL: https://github.com/apache/hive/pull/5841#discussion_r2189276915
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -513,23 +516,53 @@ public long getTargetTxnId(String replPolicy, long
sourceTxnId) throws MetaExcep
@Override
public void abortTxn(AbortTxnRequest rqst) throws NoSuchTxnException,
MetaException, TxnAbortedException {
+ List<TxnWriteDetails> txnWriteDetails = new ArrayList<>();
+ if (transactionalListeners != null) {
+ //Find the write details for this transaction.
+ //Doing it here before the metadata tables are updated below.
+ txnWriteDetails = getWriteIdsForTxnID(rqst.getTxnid());
Review Comment:
few notes:
- no need to fetch writeIds for readOnly transaction!
- if abort is not manually triggered, `DbTxnManager` tableWriteIds has all
you need, just add this to the AbortTxnRequest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
