harshal-16 commented on code in PR #5841:
URL: https://github.com/apache/hive/pull/5841#discussion_r2189614125


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -513,23 +516,53 @@ public long getTargetTxnId(String replPolicy, long 
sourceTxnId) throws MetaExcep
 
   @Override
   public void abortTxn(AbortTxnRequest rqst) throws NoSuchTxnException, 
MetaException, TxnAbortedException {
+    List<TxnWriteDetails> txnWriteDetails = new ArrayList<>();
+    if (transactionalListeners != null) {
+      //Find the write details for this transaction.
+      //Doing it here before the metadata tables are updated below.
+      txnWriteDetails = getWriteIdsForTxnID(rqst.getTxnid());

Review Comment:
   This was the main issue 
     List<WriteEventInfo> writeEventInfo =
           getMS().getAllWriteEventInfo(rqst.getTxnid(), null, null);
       rqst.setWriteEventInfo(writeEventInfo);
   
   - this uses txn_write_notification_log table to get the information, which 
has entry only in case of DML operations which generates the hdfs files
   - In case of truncate / DDLDescWithWriteId doesn't have any entry into that 
table resulting in 0 rows in case of getAllWriteEventInfo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to