zhangbutao commented on code in PR #1953:
URL: https://github.com/apache/hive/pull/1953#discussion_r2193924664
##########
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritableV2.java:
##########
@@ -374,16 +374,6 @@ public String toString() {
return timestamp.toString();
}
- String timestampString = timestamp.toString();
- if (timestampString.length() > 19) {
Review Comment:
The character length is at a maximum of 19, indicating that the current
design supports a maximum time of: **9999-12-31 23:59:59**.
This is an interesting issue. If this were a real business use case, the
year 9999 would absolutely be an unreachable limit.
So, for this PR, if users want to perform some testing based on impossible
years (>9999), then this PR might still have some meaning. Otherwise, Apache
Hive living until 9999 is already more than enough! Haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
