zhangbutao commented on code in PR #1953: URL: https://github.com/apache/hive/pull/1953#discussion_r2194647498
########## serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritableV2.java: ########## @@ -374,16 +374,6 @@ public String toString() { return timestamp.toString(); } - String timestampString = timestamp.toString(); - if (timestampString.length() > 19) { Review Comment: I don't know either. Perhaps we simply don't want to support values greater than 9999. So we only support the time format like `YYYY-MM-DD HH:MM:SS`. https://issues.apache.org/jira/browse/HIVE-24748?focusedCommentId=18004011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18004011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org