ngsg opened a new pull request, #5955:
URL: https://github.com/apache/hive/pull/5955
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch aims to support configurable IMetaStoreClient.
This patch has been submitted three times previously. Austin originally
proposed HIVE-12679 and submitted the initial patch in 2016. @moomindani later
resubmitted it in https://github.com/apache/hive/pull/1402, and then @okumin
took it over in https://github.com/apache/hive/pull/4444.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In some scenarios, users may want to run Hive as a general-purpose execution
engine on top of a third-party data catalog. For instance, [AWS Glue Data
Catalog](https://github.com/awslabs/aws-glue-data-catalog-client-for-apache-hive-metastore)
is an example of such usage, and there is also an open ticket to implement an
Iceberg REST catalog (HIVE-28658). As noted in the previous PR
(https://github.com/apache/hive/pull/4444), more than 40 people are watching
HIVE-12679, which I believe reflects strong demand for using Hive in this more
flexible architecture. Therefore, I believe it is worth completing this patch
to support external data catalogs in Hive.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, users can use the existing HMS client without any changes in their
configuration files.
For the documentation fix, I will update hive-site once this patch is
accepted and merged.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
This patch includes two simple tests loading MetaStoreClient via
`HiveMetaStoreClientFactory`.
---
Note for those familiar with the earlier patch:
- Regarding the design decision about MetaStoreClientFactory:
This patch does not support a customizable MSC factory as the original patch
did; instead, it supports a customizable MSC. In other words, this patch
introduces `metastore.client.class`, not `metastore.client.factory.class`.
I made this change not because I preferred this approach, but because I
followed the majority opinion in the discussion [here](
https://github.com/apache/hive/pull/4444#pullrequestreview-1492711587).
Personally, I think both approaches are valid and have their merits, and I do
not have a strong opinion among them. I would appreciate it if you could share
your thoughts on this decision.
- Regarding RetryingMetaStoreClient and other classes that instantiate
MetaStoreClient
([link](https://github.com/apache/hive/pull/4444#pullrequestreview-1687155221)):
After resolving HIVE-27473, Hive now creates ThriftHiveMetaStoreClient only
in `Hive.java` and `HiveMetaStoreClient`. Therefore, I believe it is sufficient
to replace these two call sites with the new `HiveMetaStoreClientFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
