dengzhhu653 commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2208998466
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1728,6 +1728,10 @@ public enum ConfVars {
" and password. Any other value is ignored right now but
may be used later."
+ "If JWT- Supported only in HTTP transport mode. If set, HMS
Client will pick the value of JWT from "
+ "environment variable HMS_JWT and set it in Authorization
header in http request"),
+ METASTORE_CLIENT_CLASS("metastore.client.class",
+ "hive.metastore.client.class",
+ "org.apache.hadoop.hive.metastore.client.ThriftHiveMetaStoreClient",
+ "The name of MetaStoreClient class that implements the
IMetaStoreClient interface."),
Review Comment:
I have a concern here: if we specify the client via the configuration, it
means each time we are allowed to query one type of metadata only. For example,
we set the client to Glue client for requesting the tables stored in Glue, if
we need to request the tables stored in Hive later on in the same session, we
might need to reset the client to Hive, and just think loud, if the SQL
contains the Hive and Glue table?
From my point of view, I would suggest the pattern(the database or table) or
the catalog routed way to choose which the client will use to obtain the
metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
