ramitg254 commented on code in PR #5947:
URL: https://github.com/apache/hive/pull/5947#discussion_r2199671525
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java:
##########
@@ -245,7 +245,7 @@ private int callHCatCli(String[] args) throws Exception {
private void silentDropDatabase(String dbName) throws MetaException,
TException {
try {
- for (String tableName : msc.getTables(dbName, "*")) {
+ for (String tableName : msc.getTables(dbName, "*", null)) {
Review Comment:
and these simplified api are just wrappers around the current methods which
was asked to be removed in
[HIVE-23971](https://issues.apache.org/jira/browse/HIVE-23971](https://issues.apache.org/jira/browse/HIVE-23971#:~:text=Also%20affects-,getTables%20,-API.%20Bumping%20this))
and all of these parameters can be dealt by
https://github.com/apache/hive/pull/5947/files#:~:text=static%20GetTablesRequest-,convertToGetTablesRequest,-(String%20catName
other than tableType cause it is not part of `GetTablesRequest` object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
