deniskuzZ commented on code in PR #5947:
URL: https://github.com/apache/hive/pull/5947#discussion_r2201604203
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java:
##########
@@ -245,7 +245,7 @@ private int callHCatCli(String[] args) throws Exception {
private void silentDropDatabase(String dbName) throws MetaException,
TException {
try {
- for (String tableName : msc.getTables(dbName, "*")) {
+ for (String tableName : msc.getTables(dbName, "*", null)) {
Review Comment:
isn't it more convenient to use `msc.getTables(dbName, "*") ->
msc.getTables(dbName, "*", null)` than hardcoding nulls?
btw, you can just drop the public API, you have to deprecate it first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
