ngsg commented on code in PR #5924:
URL: https://github.com/apache/hive/pull/5924#discussion_r2199991758
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/TableIterable.java:
##########
Review Comment:
It seems that the tab size is set to 4 inside `Iterator { }`. Could we
restore it to 2?
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -92,7 +92,7 @@
import org.apache.hadoop.hive.metastore.api.TableValidWriteIds;
import org.apache.hadoop.hive.metastore.api.UniqueConstraintsRequest;
import org.apache.hadoop.hive.metastore.api.UniqueConstraintsResponse;
-import org.apache.hadoop.hive.metastore.client.HiveMetaStoreClientUtils;
+import org.apache.hadoop.hive.metastore.client.utils.HiveMetaStoreClientUtils;
Review Comment:
The same import order issue here.
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java:
##########
@@ -65,15 +67,21 @@ public class RetryingMetaStoreClient implements
InvocationHandler {
private final UserGroupInformation ugi;
private final int retryLimit;
private final long retryDelaySeconds;
- private final ConcurrentHashMap<String, Long> metaCallTimeMap;
+ private final Map<String, Long> metaCallTimeMap;
Review Comment:
What do you think about removing all uses of `ConcurrentHashMap` from this
file? It seems that only one method uses `ConcurrentHashMap`, and the actual
value passed to that method is always null.
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/builder/HiveMetaStoreClientBuilder.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.client.builder;
+
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.metastore.HiveMetaHookLoader;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+
Review Comment:
Could we remove the empty line and sort the import list?
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreClientWithLocalCache.java:
##########
@@ -41,7 +41,7 @@
import org.apache.hadoop.hive.metastore.api.PartitionsByExprRequest;
import org.apache.hadoop.hive.metastore.api.PartitionsStatsRequest;
import org.apache.hadoop.hive.metastore.api.Table;
-import org.apache.hadoop.hive.metastore.client.HiveMetaStoreClientUtils;
+import org.apache.hadoop.hive.metastore.client.utils.HiveMetaStoreClientUtils;
Review Comment:
I think the order of import might be swapped as follows:
```
import org.apache.hadoop.hive.metastore.client.MetaStoreClientWrapper;
import
org.apache.hadoop.hive.metastore.client.utils.HiveMetaStoreClientUtils;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
