okumin commented on code in PR #5924:
URL: https://github.com/apache/hive/pull/5924#discussion_r2204523274
##########
metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java:
##########
@@ -107,7 +107,7 @@ public HiveClientCache(final int timeout) {
/**
* @param timeout the length of time in seconds after a client is created
that it should be automatically removed
*/
- private HiveClientCache(final int timeout, final int initialCapacity, final
int maxCapacity, final boolean enableStats) {
+ protected HiveClientCache(final int timeout, final int initialCapacity,
final int maxCapacity, final boolean enableStats) {
Review Comment:
Since a protected constructor is directly invisible from HCatUtil, we create
it as an anonymous class that inherits `HiveClientCache`.
```
hiveClientCache = new HiveClientCache(
hiveConf.getInt(
HCAT_HIVE_CLIENT_EXPIRY_TIME,
DEFAULT_HIVE_CACHE_EXPIRY_TIME_SECONDS),
hiveConf.getInt(
HCAT_HIVE_CLIENT_CACHE_INITIAL_CAPACITY,
DEFAULT_HIVE_CACHE_INITIAL_CAPACITY),
hiveConf.getInt(
HCAT_HIVE_CLIENT_CACHE_MAX_CAPACITY,
DEFAULT_HIVE_CACHE_MAX_CAPACITY),
hiveConf.getBoolean(
HCAT_HIVE_CLIENT_CACHE_STATS_ENABLED,
DEFAULT_HIVE_CLIENT_CACHE_STATS_ENABLED))
{}; // ← THIS PART
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
