deniskuzZ commented on code in PR #5223:
URL: https://github.com/apache/hive/pull/5223#discussion_r2202683892


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -1449,26 +1452,39 @@ public boolean dropPartition(String catName, String 
dbName, String tableName, St
 
   @Override
   public List<Partition> dropPartitions(String catName, String dbName, String 
tblName,
-      List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options) 
throws TException {
+                                        RequestPartsSpec partsSpec, 
PartitionDropOptions options)

Review Comment:
   It seems like a breaking change. Spark, for instance, uses hive-exec-core 
and might not handle the API change well. 
   Also, why do we need to change anything here since it's not a public HMS 
client?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to