deniskuzZ commented on code in PR #5223: URL: https://github.com/apache/hive/pull/5223#discussion_r2206812521
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ########## @@ -4031,6 +4032,29 @@ public List<Partition> dropPartitions(String dbName, String tableName, } } + public List<Partition> dropPartitions(String dbName, String tableName, Review Comment: can't we reuse existing method to avoid code duplication? ```` public List<Partition> dropPartitions(String dbName, String tableName, List<Pair<Integer, byte[]>> partitionExpressions, PartitionDropOptions dropOptions) ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org