difin commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2216420228
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -213,17 +220,22 @@ protected String resolveUserToRunAs(Map<String, String>
cache, Table t, Partitio
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
+ initExecutorService();
checkInterval =
conf.getTimeVar(HiveConf.ConfVars.HIVE_COMPACTOR_CHECK_INTERVAL,
TimeUnit.MILLISECONDS);
- compactionExecutor = CompactorUtil.createExecutorWithThreadFactory(
- conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_REQUEST_QUEUE),
- COMPACTOR_INTIATOR_THREAD_NAME_FORMAT);
metricsEnabled = MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METRICS_ENABLED) &&
MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON);
optimizers = Arrays.stream(MetastoreConf.getTrimmedStringsVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_TABLE_OPTIMIZERS))
.map(this::instantiateTableOptimizer).toList();
}
+ @VisibleForTesting
+ protected void initExecutorService() {
Review Comment:
Right, package private is more restrictive then protected.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
