deniskuzZ commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2224587757
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -82,19 +87,35 @@ private static IMetaStoreClient
createUnderlyingClient(Configuration conf, HiveM
// methods for test
public boolean createType(Type type) throws TException {
- return thriftClient.createType(type);
+ if (thriftClient != null) {
Review Comment:
how about using generic method?
````
@FunctionalInterface
interface ThriftCallable<T> {
T call() throws TException;
}
private <T> T doCall(ThriftCallable<T> callable) throws TException {
if (thriftClient != null) {
return callable.call();
} else {
throw new UnsupportedOperationException();
}
}
public boolean createType(Type type) throws TException {
return doCall(() -> thriftClient.createType(type));
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
