Aggarwal-Raghav commented on code in PR #5976: URL: https://github.com/apache/hive/pull/5976#discussion_r2224662016
########## ql/src/test/results/clientpositive/llap/msck_repair_9.q.out: ########## @@ -90,7 +90,7 @@ PREHOOK: Output: default@tbl_y POSTHOOK: query: MSCK REPAIR TABLE tbl_y POSTHOOK: type: MSCK POSTHOOK: Output: default@tbl_y -Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=12/day=__HIVE_DEFAULT_PARTITION__ tbl_y:month=ANOTHER_PARTITION/day=3 +Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=ANOTHER_PARTITION/day=3 Review Comment: @vikramahuja1001 , i would recomment you to check the disucssion in this thread https://github.com/apache/hive/pull/5568#discussion_r1871258402 . Based on this discussion only I went ahead allowing any string partition name. **My understanding is this**: If user is adding a string partition name in non-string column then its user's responsibility and he should be consistent with the default partition name for that table. As DEFAULT PARTITION is configurable at session level, we can't stop user from changing it / playing around. Imposing checks done in your current PR will be a breaking change b/w 4.0.1 and next hive release version and forcing users to set this on cluster level `hive.msck.path.validation=skip` from what I can infer from modified msck_repair_9.q -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
