deniskuzZ commented on code in PR #5976: URL: https://github.com/apache/hive/pull/5976#discussion_r2230695349
########## ql/src/test/results/clientpositive/llap/msck_repair_9.q.out: ########## @@ -90,7 +90,7 @@ PREHOOK: Output: default@tbl_y POSTHOOK: query: MSCK REPAIR TABLE tbl_y POSTHOOK: type: MSCK POSTHOOK: Output: default@tbl_y -Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=12/day=__HIVE_DEFAULT_PARTITION__ tbl_y:month=ANOTHER_PARTITION/day=3 +Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=ANOTHER_PARTITION/day=3 Review Comment: It makes sense to me, however, I might be missing some edge-cases. @vikramahuja1001, could you please clarify again what happens in the scenario below >INSERT INTO tbl_x (id, name, month) values(3, 'ccc', 12); PARTITION(month=12,day=HIVE_DEFAULT_PARTITION) >SET hive.exec.default.partition.name=ANOTHER_PARTITION; >INSERT INTO tbl_x (id, name, day) values(4, 'ddd', 3); PARTITION(month=ANOTHER_PARTITION,day=3) >MSCK REPAIR TABLE tbl_x; Do we log a warning for `PARTITION(month=12,day=__HIVE_DEFAULT_PARTITION__)` or fail ? ########## ql/src/test/results/clientpositive/llap/msck_repair_9.q.out: ########## @@ -90,7 +90,7 @@ PREHOOK: Output: default@tbl_y POSTHOOK: query: MSCK REPAIR TABLE tbl_y POSTHOOK: type: MSCK POSTHOOK: Output: default@tbl_y -Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=12/day=__HIVE_DEFAULT_PARTITION__ tbl_y:month=ANOTHER_PARTITION/day=3 +Partitions not in metastore: tbl_y:month=12/day=2 tbl_y:month=12/day=3 tbl_y:month=ANOTHER_PARTITION/day=3 Review Comment: It makes sense to me, however, I might be missing some edge-cases. @vikramahuja1001, could you please clarify again what happens in the scenario below >INSERT INTO tbl_x (id, name, month) values(3, 'ccc', 12); PARTITION(month=12,day=HIVE_DEFAULT_PARTITION) >SET hive.exec.default.partition.name=ANOTHER_PARTITION; >INSERT INTO tbl_x (id, name, day) values(4, 'ddd', 3); PARTITION(month=ANOTHER_PARTITION,day=3) >MSCK REPAIR TABLE tbl_x; Do we log a warning for `PARTITION(month=12,day=__HIVE_DEFAULT_PARTITION__)` or fail ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
