okumin commented on code in PR #5882: URL: https://github.com/apache/hive/pull/5882#discussion_r2259166224
########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ########## @@ -33,21 +33,23 @@ /** * Catalog & servlet factory. + * <p>This class is derivable on purpose; the factory class name is a configuration property, this class + * can serve as a base for specialization.</p> Review Comment: Just for your information, I'm not confident about what our way should be. It may turn out that you may be right. Regardless of the decision, this PR looks awesome already 🏆 ; The caching feature is probably more needed than the convenience of the potential user-side extensibility. As our dev or review capacity is limited[1], I prefer to merge the important part first. - [1] [I review many PRs in parallel](https://okumin.com/wip/), but I can work with my laptop for only 1-2 hours per day because of a medical reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
