InvisibleProgrammer commented on PR #6115: URL: https://github.com/apache/hive/pull/6115#issuecomment-3381725531
This PR contains ~1400 file changes in 45 commits. Most of the changes are generated. Could you please clarify which files/commits worth reviewing? Is there a script that generated the changes or a plugin execution? If yes, what was the tool or command that you ran? TBH, I'm afraid, in that format the change will be squashed onto one single commit and later, it will be extremely hard to figure out what happened. Is it possible to create two commits instead of 45? One commit for the changes around the rules, exceptions, generator script, etc. And one for the generated content. In that way the git history will be obvious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
