InvisibleProgrammer commented on PR #6115: URL: https://github.com/apache/hive/pull/6115#issuecomment-3385553152
> If we switch to the following PR, is it possible to review it? > https://github.com/apache/hive/pull/6122 TBH, I see no difference. The second PR has more than 700 file changes. And it doesn't even build due to the pom.xml of storage-api. It contains 9 commits. And still, nothing shows what script modified the files. Honestly, I love the concept of fixing those header files and forcing having the proper header files. But at this PR I don't see how the change can properly reviewed. And also, the thing that actually happens, still hidden. I mean, it is possible to spot the extra checks after the change. But it is not possible to spot how it changed. Is there a script that did the change. I give you one example about what I'm thinking about: Iceberg applied spotless back then. It ended up changing more than 3000 files. But it happened in only a few, individually understandable commits. And all the generated changes are in a single one commit. And this commit doesn't contain anything but a generated content. In that way, it is easy to understand what happened and how happened. And also, it is easy to repeat the process if it is required. [Ihttps://github.com/apache/iceberg/pull/5312/commits](https://github.com/apache/iceberg/pull/5312/commits) At this PR, it is easy to understand the end goal. But I don't see the how. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
