deniskuzZ commented on code in PR #6081:
URL: https://github.com/apache/hive/pull/6081#discussion_r2416154556
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java:
##########
@@ -179,13 +183,29 @@ public class DagUtils {
public static final String TEZ_TMP_DIR_KEY = "_hive_tez_tmp_dir";
private static final Logger LOG =
LoggerFactory.getLogger(DagUtils.class.getName());
private static final String TEZ_DIR = "_tez_scratch_dir";
- private static final DagUtils instance = new
DagUtils(defaultCredentialSuppliers());
+ private static final DagUtils instance = new DagUtils();
// The merge file being currently processed.
public static final String TEZ_MERGE_CURRENT_MERGE_FILE_PREFIX =
"hive.tez.current.merge.file.prefix";
// A comma separated list of work names used as prefix.
public static final String TEZ_MERGE_WORK_FILE_PREFIXES =
"hive.tez.merge.file.prefixes";
- private final List<DagCredentialSupplier> credentialSuppliers;
+ private static final List<DagCredentialSupplier> credentialSuppliers = new
ArrayList<>();
+
+ /**
+ * MANDATORY Table property indicating kafka broker(s) connection string.
+ */
+ private static final String HIVE_KAFKA_BOOTSTRAP_SERVERS =
"kafka.bootstrap.servers";
Review Comment:
could we use constants from KafkaTableProperties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
