Indhumathi27 commented on code in PR #6042:
URL: https://github.com/apache/hive/pull/6042#discussion_r2429662160
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6465,6 +6465,21 @@ public List<Function> getFunctionsInDb(String dbName,
String pattern) throws Hiv
public void setMetaConf(String propName, String propValue) throws
HiveException {
try {
+ /*
+ * Updates the 'conf' object with session-level metastore variables
+ * ('metaConfVars'). This object is used to initialize the
+ * Thrift client connection to the Hive Metastore, ensuring that any
+ * session-specific overrides are propagated to the underlying
connection.
+ *
+ * For reference on how this 'conf' object is consumed, see the client
+ * instantiation logic in:
+ * org.apache.hadoop.hive.ql.metadata.Hive#createMetaStoreClient()
+ */
+ if (Arrays.stream(MetastoreConf.metaConfVars)
Review Comment:
I suggest to remove the deprecated Hivename MetaConf Variables and use
Metastore configurations only. If not, both metaconf:hivename= and hive conf
variables related to metastore should behave consistent, as they are intended
for the same purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
