Aggarwal-Raghav commented on code in PR #6042:
URL: https://github.com/apache/hive/pull/6042#discussion_r2404566064
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -244,18 +243,26 @@ public String toString() {
ConfVars.AGGREGATE_STATS_CACHE_MAX_READER_WAIT,
ConfVars.AGGREGATE_STATS_CACHE_MAX_FULL,
ConfVars.AGGREGATE_STATS_CACHE_CLEAN_UNTIL,
- ConfVars.DISALLOW_INCOMPATIBLE_COL_TYPE_CHANGES,
ConfVars.FILE_METADATA_THREADS,
ConfVars.METASTORE_CLIENT_FILTER_ENABLED,
ConfVars.METASTORE_SERVER_FILTER_ENABLED,
ConfVars.METASTORE_PARTITIONS_PARAMETERS_INCLUDE_PATTERN,
- ConfVars.METASTORE_PARTITIONS_PARAMETERS_EXCLUDE_PATTERN
+ ConfVars.METASTORE_PARTITIONS_PARAMETERS_EXCLUDE_PATTERN,
+ // Add metaConfVars here as well
Review Comment:
Please check the top comment during initializing `metaVars`. If the config
value is changed for any of these Confvars, it will create new HMS client
connection.
Code flow when user do: `set metaconf:metastore.try.direct.sql=false;`
```
SetProcessor.java (Hive hive = Hive.get(ss.getConf()) -> Hive.java
(getInternal(..)) -> Hive.java
(isCompatible() ... -> ThriftHiveMetaStoreClient#isCompatibleWith() which
returns false and causes to create new HMS Client connection
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
