okumin commented on PR #6125: URL: https://github.com/apache/hive/pull/6125#issuecomment-3413860475
@InvisibleProgrammer Thanks for proposing. Probably, I could not explain the problem statement clearly. As a Hive committer, I review all reports from SonarQube and don't merge pull requests with addressable issues. So, "nobody reads the warnings" doesn't apply to me. <img width="922" height="354" alt="image" src="https://github.com/user-attachments/assets/7a37f2be-3b70-403d-a79b-4dda68ae20c9"; /> As a PR author and reviewer, I spent some time on the header issue, as well as we consumed CI resources. There are two reasons. (1) I copy and paste them from existing files. (2) The error message is a little confusing. As a PR author, [I struggled to find the SonarQube's mechanism and fix them](https://github.com/apache/hive/compare/b2ae59acd1db187eccb2caa75ef8ec7ec8a46850..8fc12154148b4f177ca0937072ec420c3eb15975). As a reviewer, I put two comments to resolve the header issue completely ([first](https://github.com/apache/hive/pull/6108#discussion_r2397297905), [second](https://github.com/apache/hive/pull/6108#discussion_r2400666630)). <img width="908" height="129" alt="image" src="https://github.com/user-attachments/assets/0a99f00f-7947-44cf-8537-756387c91744"; /> I assume each contributor no longer needs to spend human minutes + CI resources once we spend a couple of hours resolving the issue. I'm open to alternative solutions or alternative ideas(e.g., discontinue the SonarQube integration). Also, since this is not urgent or critical, I'm open to voiding this ticket or putting off reviews. We can say "checkstyle/asf.header is the source of truth" on each pull request. We can revisit here once we feel it should be addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
