InvisibleProgrammer commented on PR #6125: URL: https://github.com/apache/hive/pull/6125#issuecomment-3400689430
Hi, I did the following to check this out: - checked out master - added the checkstyle rules and the asf.header.incremental files to the following: -- checkstyle/checkstyle.xml -- standalone-metastore/checkstyle/checkstyle.xml -- storage-api/checkstyle/checkstyle.xml - reviewed and ran the regex script - ran `mvn checkstyle:check` The interesting thing that I experienced, that I got green checkstyle run just after those changes. So, at this point, I think I miss something or don't understand a couple of things. Could you please help answering the following: - My run changed only half of the files mentioned in this PR. It is a significant difference. Is there an additional script that collects files with incorrect header format? - What is the reason of the suppressions? The checkstyle run for me went well without them. - Why do we need the configuration exclusion at storage-api? Additionally, I pushed my changes into a branch. Could you please check if I missed something in it? https://github.com/apache/hive/compare/master...InvisibleProgrammer:hive:header_checkstyle?expand=1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
