saihemanth-cloudera commented on code in PR #5929:
URL: https://github.com/apache/hive/pull/5929#discussion_r2430735907
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -9621,6 +9624,9 @@ public Map<String, String>
updatePartitionColumnStatistics(Table table, MTable m
if (partition == null) {
throw new NoSuchObjectException("Partition for which stats is gathered
doesn't exist.");
}
+ lockForUpdate("PARTITIONS", "PART_ID", "\"TBL_ID\" = " + mTable.getId()
Review Comment:
lockForUpdate() is calling directSql.lockDbTable(tableName)#L11464; and
MetaStoreDirectSql#lockDbTable(String tableName) has this code
`String lockCommand = "lock table \"" + tableName + "\" in exclusive mode";
try {
executeNoResult(lockCommand);
} catch (SQLException sqle) {
throw new MetaException("Error while locking table " + tableName + ":
" + sqle.getMessage());
}`
So we are indeed locking the table in exclusive mode, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
