harshal-16 commented on code in PR #6088:
URL: https://github.com/apache/hive/pull/6088#discussion_r2458946185
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java:
##########
@@ -264,8 +265,9 @@ private Task<?> dbUpdateReplStateTask(String dbName, String
replState, Task<?> p
HashMap<String, String> mapProp = new HashMap<>();
mapProp.put(ReplicationSpec.KEY.CURR_STATE_ID_SOURCE.toString(),
replState);
- AlterDatabaseSetPropertiesDesc alterDbDesc = new
AlterDatabaseSetPropertiesDesc(dbName, mapProp,
- new ReplicationSpec(replState, replState));
+ // TODO catalog. Need to double check the actual catalog here. Depend on
HIVE-29278
+ AlterDatabaseSetPropertiesDesc alterDbDesc = new
AlterDatabaseSetPropertiesDesc(HiveUtils.getCurrentCatalogOrDefault(conf),
Review Comment:
Just checked the details in the main JIRA:
https://issues.apache.org/jira/browse/HIVE-28879
As ACID tables can only reside in Hive (default), other catalogs don't make
sense in case of replication here
Also, during dump operation itself, it filters only default catalog here:
https://github.com/apache/hive/blob/d2bd35394d82ef5dc778e3c2c193288e29e63187/ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java#L923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
