harshal-16 commented on code in PR #6088:
URL: https://github.com/apache/hive/pull/6088#discussion_r2459669634


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java:
##########
@@ -264,8 +265,9 @@ private Task<?> dbUpdateReplStateTask(String dbName, String 
replState, Task<?> p
     HashMap<String, String> mapProp = new HashMap<>();
     mapProp.put(ReplicationSpec.KEY.CURR_STATE_ID_SOURCE.toString(), 
replState);
 
-    AlterDatabaseSetPropertiesDesc alterDbDesc = new 
AlterDatabaseSetPropertiesDesc(dbName, mapProp,
-        new ReplicationSpec(replState, replState));
+    // TODO catalog. Need to double check the actual catalog here. Depend on 
HIVE-29278
+    AlterDatabaseSetPropertiesDesc alterDbDesc = new 
AlterDatabaseSetPropertiesDesc(HiveUtils.getCurrentCatalogOrDefault(conf),

Review Comment:
   Oh, then I think we will need to update the incremental dump filter also to 
make it consistent with the load.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to