dengzhhu653 commented on code in PR #6240: URL: https://github.com/apache/hive/pull/6240#discussion_r2752146313
########## ql/src/test/results/clientpositive/llap/ppd_like_filter.q.out: ########## @@ -256,3 +256,51 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@test_tbl POSTHOOK: Input: default@test_tbl@b=d_%5C%25ae #### A masked pattern was here #### +PREHOOK: query: select * from test_tbl where b like 'a.*' Review Comment: > we don't have a single pattern for both jdo and the direct sql, jdo accepts .* (Java-type pattern) for any sequences and the sql allows _% for the same game. I tried some similar, but I found it was difficult to me, https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L2211-L2218 I've just done a small part of transformation between jdo and sql pattern, and it's difficult to add the tests to cover it. > When comes to HMS API, the user needs to take care of the pattern, whether it should be a Java-type pattern or sql pattern. What do you think about this way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
