dengzhhu653 commented on code in PR #6240: URL: https://github.com/apache/hive/pull/6240#discussion_r2766587319
########## ql/src/test/results/clientpositive/llap/ppd_like_filter.q.out: ########## @@ -256,3 +256,51 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@test_tbl POSTHOOK: Input: default@test_tbl@b=d_%5C%25ae #### A masked pattern was here #### +PREHOOK: query: select * from test_tbl where b like 'a.*' Review Comment: The jdo like is much more complex than the sql type. In the direct sql we assume the like is a Jdo pattern, and the sql pattern in the jdo query for the same API, `ObjectStore#getPartitionsByFilter` for example, this could make things worse, if we disable the direct sql, it could give us a different answer for the same input. > do you think we should not support java pattern filter? We use the Java filter somewhere, the `tablePattern` in getTableObjectsByName for example. If an ObjectStore API has implemented the direct sql or going to be, then for this API, I would suggest the sql type pattern for the filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
