zabetak commented on code in PR #6092:
URL: https://github.com/apache/hive/pull/6092#discussion_r2821575419
##########
ql/src/test/results/clientpositive/perf/tpcds30tb/cte/cbo_query11.q.out:
##########
@@ -34,58 +34,50 @@ HiveSortLimit(sort0=[$0], sort1=[$1], sort2=[$2],
sort3=[$3], dir0=[ASC], dir1=[
HiveAggregate(group=[{5, 8}], agg#0=[sum($2)])
HiveJoin(condition=[=($4, $0)], joinType=[inner],
algorithm=[none], cost=[not available])
HiveJoin(condition=[=($1, $3)], joinType=[inner],
algorithm=[none], cost=[not available])
- HiveProject(ss_customer_sk=[$0], ss_sold_date_sk=[$3],
$f8=[-($2, $1)])
- HiveFilter(condition=[AND(IS NOT NULL($0), IS NOT
NULL($3))])
- HiveProject(ss_customer_sk=[$2],
ss_ext_discount_amt=[$13], ss_ext_list_price=[$16], ss_sold_date_sk=[$22])
- HiveTableScan(table=[[default, store_sales]],
table:alias=[store_sales])
- HiveProject(d_date_sk=[$0])
- HiveFilter(condition=[=($1, 2000)])
- HiveProject(d_date_sk=[$0], d_year=[$6])
- HiveTableScan(table=[[default, date_dim]],
table:alias=[date_dim])
- HiveProject(c_customer_sk=[$0], c_customer_id=[$1],
c_first_name=[$8], c_last_name=[$9], c_birth_country=[$14])
- HiveTableScan(table=[[default, customer]],
table:alias=[customer])
- HiveProject(customer_id=[$0], year_total=[$1], EXPR$0=[>($1,
0:DECIMAL(1, 0))])
- HiveFilter(condition=[>($1, 0:DECIMAL(1, 0))])
- HiveAggregate(group=[{5}], agg#0=[sum($2)])
- HiveJoin(condition=[=($4, $0)], joinType=[inner],
algorithm=[none], cost=[not available])
- HiveJoin(condition=[=($1, $3)], joinType=[inner],
algorithm=[none], cost=[not available])
+ HiveTableSpool(table=[[cte, cte_suggestion_2]])
HiveProject(ss_customer_sk=[$0], ss_sold_date_sk=[$3],
$f8=[-($2, $1)])
HiveFilter(condition=[AND(IS NOT NULL($0), IS NOT
NULL($3))])
HiveProject(ss_customer_sk=[$2],
ss_ext_discount_amt=[$13], ss_ext_list_price=[$16], ss_sold_date_sk=[$22])
HiveTableScan(table=[[default, store_sales]],
table:alias=[store_sales])
+ HiveTableSpool(table=[[cte, cte_suggestion_1]])
HiveProject(d_date_sk=[$0])
- HiveFilter(condition=[=($1, 1999)])
+ HiveFilter(condition=[=($1, 2000)])
Review Comment:
The lines in the diff are misaligned/misleading (in IntelliJ the differences
are easier to read).
Line 57 on the left corresponds to Line 57 on the right.
Line 42 on the left corresponds to Line 44 on the right.
The filters are identical so there is no issue here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
