zabetak commented on PR #6092: URL: https://github.com/apache/hive/pull/6092#issuecomment-3920079828
@deniskuzZ Many thanks for the review. I believe I addressed all your comments so please take another look once you get the chance. > HiveConf default AST, but we test with CBO, is that intentional? Regarding the test coverage for `hive.optimize.cte.suggester.type` I kept the default to AST to avoid changes in behavior. In addition CBO is an experimental feature so not ready yet for being the default. The AST is the default value and is tested as part of the main plan regression suite (TezTPCDS30TBCliConfig) as well as everywhere else where the config is not overridden. The CBO is an experimental feature, and the main reason that we introduced a separate CTE suite (TPCDSCteCliConfig). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
