soumyakanti3578 commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2843837941
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##########
@@ -276,7 +278,7 @@ private LockInfo createLock() throws LockException {
}
LockComponent lockComponent =
- new LockComponent(LockType.EXCL_WRITE, LockLevel.TABLE,
databaseName);
+ new LockComponent(LockType.EXCL_WRITE, LockLevel.TABLE,
databaseName, catalogName);
Review Comment:
nit: It might be more readable if the order of `databaseName` and
`catalogName` is flipped. But this is not required for merging this PR.
##########
parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:
##########
@@ -1346,7 +1346,7 @@ showStatement
| KW_SHOW KW_TBLPROPERTIES tableName (LPAREN prptyName=StringLiteral
RPAREN)? -> ^(TOK_SHOW_TBLPROPERTIES tableName $prptyName?)
| KW_SHOW KW_LOCKS
(
- (KW_DATABASE|KW_SCHEMA) => (KW_DATABASE|KW_SCHEMA) (dbName=identifier)
(isExtended=KW_EXTENDED)? -> ^(TOK_SHOWDBLOCKS $dbName $isExtended?)
+ (KW_DATABASE|KW_SCHEMA) => (KW_DATABASE|KW_SCHEMA) (name=databaseName)
(isExtended=KW_EXTENDED)? -> ^(TOK_SHOWDBLOCKS $name $isExtended?)
Review Comment:
nit: Just trying to understand why are we changing the variable name from
`dbName` to `name` here when `dbName` is more descriptive and apt?
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/BaseReplicationScenariosAcidTables.java:
##########
@@ -74,6 +74,7 @@ public class BaseReplicationScenariosAcidTables {
static WarehouseInstance primary;
static WarehouseInstance replica, replicaNonAcid;
static HiveConf conf;
+ String primaryCatName = "hive";
Review Comment:
It seems this can be a `static final` variable, and the name should be all
caps separated by `_`. Also, the scope can be something other than default,
based on the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
