Neer393 commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2844235256
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreLock.java:
##########
@@ -276,7 +278,7 @@ private LockInfo createLock() throws LockException {
}
LockComponent lockComponent =
- new LockComponent(LockType.EXCL_WRITE, LockLevel.TABLE,
databaseName);
+ new LockComponent(LockType.EXCL_WRITE, LockLevel.TABLE,
databaseName, catalogName);
Review Comment:
This cannot be done as the changes for LockComponent are made in
hive_metastore.thrift file for which, new additions have to be done at the end
as if I add catalogname before databasename and change the field ids of all
other fields, it will break backward compatibility. Hence I think this is the
only way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
