Neer393 commented on code in PR #6314: URL: https://github.com/apache/hive/pull/6314#discussion_r2850817561
########## standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift: ########## @@ -3308,8 +3311,8 @@ PartitionsResponse get_partitions_req(1:PartitionsRequest req) void add_serde(1: SerDeInfo serde) throws(1:AlreadyExistsException o1, 2:MetaException o2) SerDeInfo get_serde(1: GetSerdeRequest rqst) throws(1:NoSuchObjectException o1, 2:MetaException o2) - LockResponse get_lock_materialization_rebuild(1: string dbName, 2: string tableName, 3: i64 txnId) - bool heartbeat_lock_materialization_rebuild(1: string dbName, 2: string tableName, 3: i64 txnId) + LockResponse get_lock_materialization_rebuild(1: string catName, 2: string dbName, 3: string tableName, 4: i64 txnId) Review Comment: I have made changes as asked and also added a unit test and a qtest with different catalog. I have addressed all comments and fixed the indentation issues raised by sonar qube as well. Only this comment is to be validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
