ramitg254 commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2973613215
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:
##########
@@ -581,8 +581,7 @@ public static Map<Integer, List<ExprNodeGenericFuncDesc>>
getFullPartitionSpecs(
CommonTree ast, Table table, Configuration conf, boolean canGroupExprs)
throws SemanticException {
String defaultPartitionName = HiveConf.getVar(conf,
HiveConf.ConfVars.DEFAULT_PARTITION_NAME);
Map<String, String> colTypes = new HashMap<>();
- List<FieldSchema> partitionKeys = table.hasNonNativePartitionSupport() ?
- table.getStorageHandler().getPartitionKeys(table) :
table.getPartitionKeys();
+ List<FieldSchema> partitionKeys = table.getSupportedPartCols();
Review Comment:
yes but it should be better to use the current one as
`table.getPartitionKeys()` throws null when no keys are there which is
different from `table.getStorageHandler().getPartitionKeys(table)` used here
which gives empty arraylist for no keys.
so with current usage it will return empty list in both scenarios and rule
out null pointer exception case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
