ramitg254 commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2973652020
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -609,25 +609,30 @@ public boolean equals(Object obj) {
return true;
}
- public List<FieldSchema> getPartCols() {
+ public List<FieldSchema> getSupportedPartCols() {
Review Comment:
updating getPartCols has direct effect on implementations related to alter
statements and stats autogather implementation in which some of them are
limited to native ones only ( like getPartCols() should return empty list for
iceberg tables even if they have keys which is required for those
implementations) which will introduce more ifs at those places and even if
after all that if we get a green run we can't be sure that everything would be
unaffected as we can't be sure that all possible scenarios affected from it are
covered by tests.
so IMHO, I think we should go for this separate api for generic use cases
and older one for native use cases.
I tried to explain my thinking more elaboratively in this comment:
https://github.com/apache/hive/pull/6337#discussion_r2916139840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
