VenuReddy2103 commented on code in PR #6399:
URL: https://github.com/apache/hive/pull/6399#discussion_r3072055704
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/MarkCleanedFunction.java:
##########
@@ -50,7 +50,7 @@ public MarkCleanedFunction(CompactionInfo info) {
public Void execute(MultiDataSourceJdbcResource jdbcResource) throws
MetaException {
NamedParameterJdbcTemplate jdbcTemplate = jdbcResource.getJdbcTemplate();
MapSqlParameterSource param;
- if (!info.isAbortedTxnCleanup()) {
+ if (!info.isAbortedTxnCleanup() && !info.isSoftDelete()) {
Review Comment:
Actually table related entries from TXN_COMPONENTS would have been deleted
when table is dropped. So we don’t need to call `removeTxnComponents()` here if
soft delete is true.
We just need to remove table entry from COMPACTION_QUEUE when soft delete is
true and that happens in `removeCompactionAndAbortRetryEntries()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
